search

CollectionBuilder / collectionbuilder-csv

CollectionBuilder-CSV is a "stand alone" template for creating digital collection and exhibit websites using Jekyll and a metadata CSV.
MIT License
21 stars 16 forks source link

Links to items from data.html not working #39

Closed jawalsh closed 1 year ago

jawalsh commented 1 year ago

Using the compound objects branch, the links to items from data.html don't seem to be working. They are not include the baseurl variable in the link. Here is an example: https://biblicon.org/cbp/data.html. All the other URLs on the site seem to be fine and include the baseurl.

dcnb commented 1 year ago

Hey @jawalsh! Looks like that is my fault ... And @evanwill fixed the issue in the branch five days ago. I'm going to never live this down ...

If you look at Evan's commit, you can see the edit he made:

https://github.com/CollectionBuilder/collectionbuilder-csv/commit/60f6bef20623d2c4465a90f009e0e8ee9665d46c

So if you replace your repostory's /assets/js/metadata.min.json file with this one, the links should work.

My apologies!

dcnb commented 1 year ago

Here's the link I didn't include, with the corrected table data file:

https://github.com/CollectionBuilder/collectionbuilder-csv/blob/compound-objects/assets/js/metadata.min.json

evanwill commented 1 year ago

@jawalsh there is still quite a few bugs we are working on listed in #37 (several like this one related to removing relative_url in various places!). Once it gets sorted out, we can help you update your project--but feel free to keep working, since the data structure and basic look will be the same.

jawalsh commented 1 year ago

Great! Thank you both, @evanwill and @dcnb. I'll update that file and keep going.