CollectionBuilder / collectionbuilder-csv

CollectionBuilder-CSV is a "stand alone" template for creating digital collection and exhibit websites using Jekyll and a metadata CSV.

MIT License

21 stars 16 forks source link

Change page narrow #90

Open evanwill opened 3 months ago

evanwill commented 3 months ago

Proposed changes

simplifies page-narrow layout, rather than matching about layout, is simply a narrowed content block.

Types of changes

[ ] New feature (non-breaking change which adds functionality).
[x] Enhancement (non-breaking change which enhances functionality)
[x] Bug Fix (non-breaking change which fixes an issue).
[ ] Breaking change (fix or feature that would cause existing functionality to change).

evanwill commented 3 months ago

@owikle @dcnb this was annoying me not just having a narrow page vs a different version of about page layout. Sound okay?

owikle commented 3 months ago

@evanwill looks good to me and seems like a logical way to do it. What's the narrow-content class meant for though? Nothing's using it. Is it just supposed to be a catch-all add to any elements not listed under about-contents?

evanwill commented 3 months ago

.narrow-content was so you can add the class to anything that you want to be in the narrow block, same as .about-narrowed-content (but scoped to the old .page-narrow instead of the .about-contents). I just moved it into .about-contents just in case it was used--so now it is just the same as .about-narrowed-content, but I kind of like it better... could be removed, or also rename .about-narrowed-content to make it less verbose (like .narrowed-content)?