search

CollectionBuilder / collectionbuilder-gh

A framework for creating digital exhibits from a folder of files and a spreadsheet. See Readme below for instructions to get started!
https://collectionbuilder.github.io/collectionbuilder-gh/
MIT License
92 stars 75 forks source link

Website doesn't look like the demo one #65

Closed dersuchendee closed 1 year ago

dersuchendee commented 1 year ago

I tried to follow the steps and it worked, but it seems the website doesn't look like the demo one. Is some asset missing? The style seems off/different, some buttons are over the place, and I have just modified the content a little (e.g. images, metadata, description).

My website: https://dersuchendee.github.io/trovalarana-liceogalvani/

evanwill commented 1 year ago

@dersuchendee in a commit you removed the yaml front matter from custom.scss. That means that Jekyll won't process the file, thus it doesn't exist on your final website--so you don't have the custom CSS file to provide the styles.

Did you delete the yaml header to fix some other error you were getting?

dersuchendee commented 1 year ago

Yeah I had a build error when building the bundle, I looked up on google and it seemed like there was some incompatibility... is there any way to keep it without having issues?

EDIT: I added it again now and it works! Thank you

evanwill commented 1 year ago

@dersuchendee there is a really weird bug we just discovered yesterday too that sass-converter isn't working correctly with "custom.scss" with the most current Jekyll packages--it is something really odd, like an invisible character encoding issue. I fixed it on my demo by renaming "custom.scss" to "main.scss" (and changing the head.html include to reference that instead of "custom.scss"), and the error went away. I am trying to figure out what the issue is... it will apply to your local machine, but the automatic GitHub Pages build uses old jekyll packages, so your build should still work there.

evanwill commented 1 year ago

@dersuchendee you were impacted by the bug described in this discussion. If you want the build to work on your local machine, try renaming the "custom.scss" as described in the discussion post. The issue is fixed in the CB templates now!