search

CollectionBuilder / collectionbuilder-sa_draft

experimental version of collectionbuilder, probably don't use! We've started to call this version CollectionBuilder-ES (Elastic!).
MIT License
0 stars 1 forks source link

featured-image include is dependent on CONTENTdm #42

Open derekenos opened 4 years ago

derekenos commented 4 years ago

https://github.com/CollectionBuilder/collectionbuilder-sa_draft/blob/master/_includes/image/featured-image.html

dcnb commented 4 years ago

This should be fixed by commit https://github.com/CollectionBuilder/collectionbuilder-sa_draft/commit/5e25b8b606582ea0b0a8b848138b6fe35aebbe18

derekenos commented 4 years ago

@dcnb, I noticed that after this commit I was only ever seeing the CB logo as the featured image, even when featured-image-link was specified as a value that had previously worked.

The issue appears to be that the code that you copied from the new SA version assumes that theme.yml has a single featured-image configuration option which can be either an objectid or URL, whereas the theme.yml is this repo has dedicated featured-image-objectid and featured-image-link fields.

derekenos commented 4 years ago

I assume that this repo will probably be updated to that single featured-image config at some point, but in the short term, I created a pull request here (and assigned to you) that appears to work: https://github.com/CollectionBuilder/collectionbuilder-sa_draft/pull/45