CollectionBuilder / collectionbuilder-sheets

A framework for creating digital exhibits by loading collection metadata directly from a CSV (such as a published Google Sheet!). See the readme for instructions!
https://collectionbuilder.github.io/collectionbuilder-sheets/
MIT License
9 stars 6 forks source link

building a timeline option for sheets and moving papaparse.js to foot #7

Closed dcnb closed 2 years ago

dcnb commented 2 years ago

Got this working today. Following some of the browse-js.html methods to fill out the timeline and I moved the papaparse.js to the foot so it always loads.

I think it's confusing to have a "metadata" (i.e. typical cb/jekyll option) option in the config as well. Should build this so it's totally building off just a sheet for demo purposes. Saw on the sheets page that the demo totally works, but that's misleading.

evanwill commented 2 years ago

@dcnb I put site.metadata back in because currently Jekyll won't build without it-- it is still used in non-updated parts and lots more clean up needed first. The things that are still just building off normal CB-GH metadata right now are Home page and About page (which requires some new sort of approach to replace includes), and then all the data derivatives, which we will probably just have to remove for now (and come up with some way to generate them on the fly for download?).

@dcnb I didn't totally understand your last sentences, but do you mean, like strip it down to have only what is working now? It is a partially working demo right now just replacing things in CB-GH as we fix them. But I guess could just remove features in Home, About, and Data that aren't actually functional for now?