search

CollectionBuilder / dhsi-demo-2022

Demo site for DSHI 2022
https://collectionbuilder.github.io/dhsi-demo-2022/
MIT License
0 stars 0 forks source link

Aleksandra's collection #12

Open AMitiukova opened 2 years ago

AMitiukova commented 2 years ago

link: https://amitiukova.github.io/MenuCollectionBuilder/

But the pictures are not displayed :(

dcnb commented 2 years ago

Hi Aleksandra!

There are a couple issues you should attend to.

Your metadata file should not have any spaces in it. Right now you have it listed as "menu collectionbuilder-metadata" in your _config.yml file. Why don't you use the file in your _data folder called "menucollectionbuilder-metadata" and list that as your metadata piece.

I will send you a pull request with some changes to get things working here in a bit. Don't worry!

dcnb commented 2 years ago

Ok, I sent you a pull request. Read what I put in there and merge the PR into your repository and you should have a clean start. I also moved your metadata to a new sheet (linked in the pull request) that you should use going forward.

https://github.com/AMitiukova/MenuCollectionBuilder/pull/1

AMitiukova commented 2 years ago

Hi, Devin Thank you very much for your help! Sorry, I suppose Olivia told many times during the lesson about filenames, but that's my low comprehension level. I miss some important issues. I re-watch lessons at a lower speed with subtitles afterwards and it gets better then :) I've made (I think so) all you suggested. Collection now works properly, but there is a problem with images - they are not displayed (see screenshots). Yesterday I got the same result. That makes me try and try again with metadata file and objects filenames. I noticed that extensions differ in metadata file and in the repository and fixed them but it didn't work. I have these files in .tiff actually. I'll try to re-write them into .jpeg once more and see what happens. Anyway, that's a great experience! Thank you!

ср, 8 июн. 2022 г. в 01:37, Devin Becker @.***>:

Ok, I sent you a pull request. Read what I put in there and merge the PR into your repository and you should have a clean start. I also moved your metadata to a new sheet (linked in the pull request) that you should use going forward.

AMitiukova/MenuCollectionBuilder#1 https://github.com/AMitiukova/MenuCollectionBuilder/pull/1

— Reply to this email directly, view it on GitHub https://github.com/CollectionBuilder/dhsi-demo-2022/issues/12#issuecomment-1149241227, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZQHZXYNSLUEYOD5FUZC3JLVN7FLLANCNFSM5YENPCQQ . You are receiving this because you authored the thread.Message ID: @.***>

dcnb commented 2 years ago

Sorry for not seeing this until now, Aleksandra!

The problem with your images is that the extensions have varying capital letters in them and the metadata lists the extension as being lowercase. For example:

the first item (objectid is coll001) has "898.jpg" as its filename. However, in your objects folder, that file appears as: "898.JpG".

I think you'll need to delete those items from your repository, then reupload them. It's a really sticky problem so you'll need to delete them from your folder, make a commit that your doing so, push that commit, then rename the files on your local computer so that the extensions are lowercase, then upload them again.

If you were to merge my pull request into your repository: https://github.com/AMitiukova/MenuCollectionBuilder/pull/1

that should clear up the issue. Here are some instructions on how to do that: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request#merging-a-pull-request

Good luck!