search

CollectiveIndustries / StarfleetDelta

Repository for Starfleet Delta Webpage, Database, and all in world scripts
https://www.starfleetdelta.com/
GNU General Public License v3.0
2 stars 4 forks source link

Added New login system and a sample-config #68

Closed IAmNolanPerry closed 6 years ago

IAmNolanPerry commented 6 years ago

Created a Better Login System and a new sample-config.php

IAmNolanPerry commented 6 years ago

@Morketh

If you want any other features in the login system, let me know

Morketh commented 6 years ago

I do apologize for the long delay on merging the new login system I've been called away to deal with some other tech related problems at work thats been absorbing all of my time as of late. i did manage to get the repository downloaded and the code cleaned up (just formatting and bracket structure stuff really). However once the LAMP stack on my development box was installed I've been getting 500 error on the webpage.

Ive coppied the sample config provided and filled out the required details however i still need to set up the MySQL user for the web portal to work correctly. If we could add a failsafe to notify the user/admin that DB is not configured correctly that would be much better then a blank 500 error.

IAmNolanPerry commented 6 years ago

I will create a error page

IAmNolanPerry commented 6 years ago

@Morketh Would you rather the error be returned using a function or .htaccess

Morketh commented 6 years ago

I think either or would be fine, however i dont think the .htaccess method allows for CSS layouts. Its just eye candy and unnecessary but would be nicer and friendlier for the user in the long run.

EDIT: I retract my comment as you already posted those changes :)

IAmNolanPerry commented 6 years ago

I just added a error page to the pull request, the layout uses Google's Error Page, and the code is from a repo i have https://github.com/hollowomnicron/errorpages

You can configure it to accept errors other than 404 and 500

IAmNolanPerry commented 6 years ago

Also, When you get a chance i would like to talk inworld

Morketh commented 6 years ago

Of course. Soonest ill be able to get in world will be most likely the 26th.

IAmNolanPerry commented 6 years ago

@Morketh Have you done the review yet? I would like to be able to delete the fork

Morketh commented 6 years ago

Not yet. I just got all my development tools all set up. I will mark this as a top priority, currently out of town for a funeral and as such I'm on mobile for a few days. If you still want to chat in world let me know so we can schedule a time and place.

Morketh commented 6 years ago

@hollowomnicron have you had a chance to look over the requested changes? id like to be able to merge this branch and clean up the repository. Let me know if/when you get a chance to look this over. Morketh

IAmNolanPerry commented 6 years ago

I can not do the changes, It worked on my end and I give it as is, I set it to allow edits from maintainers, I no longer do php programmng, i now focus on making Virtual OpenSim Campuses for Schools

MyNameIsKodos commented 6 years ago

I can not do the changes, It worked on my end and I give it as is, I set it to allow edits from maintainers, I no longer do php programmng, i now focus on making Virtual OpenSim Campuses for Schools

If you're not willing to support this further, then I am going to close this PR without merge. If it doesn't work on our end, we can't know it'll work for the end user.