search

CollinAlpert / Lombok.NET

.NET adaptation for Java's Lombok using Source Generators.
MIT License
309 stars 16 forks source link

Decorate inherited non-source members #58

Closed GrahamTheCoder closed 3 days ago

GrahamTheCoder commented 2 weeks ago

Thanks for the fix in #53. I spotted it was still dependent on DeclaringSyntaxReferences, which won't work for non-source symbols. Obviously I couldn't be decorating a non-source symbol, but the interface/type I'm decorating may derive from one. Hence that's the case I've tested.

I thought I'd just show one example case here with a suggested direction for the fix which may apply to other bits of the project too. I don't really have time to work on a full version of this so you're very welcome to nuke this and do your own version or continue and merge it. I just thought this was the simplest way to show what I was talking about.

Implementation formatting note: I've tried to match the combination of tabs and spaces used in the existing code, but it'd be a lot simpler to just pick one or the other to use everywhere.

TestHelper note: I noticed that if I emit a decorator with a compile error, the test doesn't fail, despite the TestHelper having code that tries to detect that situation.

CollinAlpert commented 2 weeks ago

Thanks for this! I will try to take a closer look when I have some more time on the weekend.

CollinAlpert commented 3 days ago

Due to personal reasons, I won't be able to review this for some time.

GrahamTheCoder commented 3 days ago

Thanks for the update. No worries at all! Look after yourself ☺️

GrahamTheCoder commented 3 days ago

I'll close for now so it's not hanging around half done weighing on our minds, can always reopen when either of us have time in future