Fix Docker builds for `linux/arm/v7`

CollinHeist / TitleCardMaker

Automated title card maker for Plex, Jellyfin, and Emby

https://titlecardmaker.com/

GNU General Public License v3.0

421 stars 19 forks source link

Fix Docker builds for `linux/arm/v7` #461

Closed mchangrh closed 1 month ago

CollinHeist commented 1 month ago

Hey want to rebase this to the web-ui branch? This branch is for the non-UI

mchangrh commented 1 month ago

will rebase manually

CollinHeist commented 1 month ago

Thanks! I tested this and still get build errors for that architecture. Any ideas?

mchangrh commented 1 month ago

ah, armv7. I tested on arm64. I'll have a go in my own repo

mchangrh commented 1 month ago

add /root/.cache caching for python (don't completely rebuilt when dependencies change)
segment caching to better cache individual python requirement updates
add all build dependencies for the biggest compiled packages

CollinHeist commented 1 month ago

This looks good, thanks a lot for doing it. One question - I see you made a new Dockerfile.armv7, but I don't see where that Dockerfile is being used? I would assume it'd be in the workflow, but I don't see that file called out in the build step.

mchangrh commented 1 month ago

Nice catch, added the file line and rebased to upstream

CollinHeist commented 1 month ago

This looks great - thanks again!