CollinHeist / TitleCardMaker

Automated title card maker for Plex, Jellyfin, and Emby
https://titlecardmaker.com/
GNU General Public License v3.0
413 stars 18 forks source link

BUG - the tmdb logo_language_priority configuration for "fr" no longer works #462

Closed Derekcde closed 2 weeks ago

Derekcde commented 3 weeks ago

Installation

Docker - master tag

Describe the Bug

Hello, since the last update I have this error:

[INFO] Read preference file "/config/preferences.yml"
[CRITICAL] Invalid TMDb logo language codes - must be comma-separated list of any of the following: "ar", "ar-AE", "ar-SA", "bg", "ca", "cn-CN", "cs", "da", "de-AT", "de-CH", "de-DE", "el", "en", "es-ES", "es-MX", "fa", "fi", "fr-CA", "fr-FR", "he", "hi", "hu", "id", "it-IT", "it-CH", "ja", "ka", "ko", "lb", "lt", "lv", "my", "nb-NO", "nl-BE", "nl-NL", "nn-NO", "ms-BN", "ms-MY", "ms-SG", "no", "pl", "pt-BR", "pt-PT", "ro", "ru", "sk", "sr-RS", "sv-FI", "sv-SE", "th", "tr", "uk", "uz-UZ", "vi", "zh", "zh-CN", "zh-HK", "zh-SG"
[CRITICAL] Preference file is invalid

So I tried to put fr-FR but I still get the same error

it seems that it dates from this commit

On the TMDb site they say, perhaps this would be the cause of the error?:

ISO 3166-1 You'll usually find our language codes mated to a country code in the format of en-US. The country codes in use here are ISO 3166-1.

📘 Note

Images do not yet support the language-COUNTRY notation. This will be improved in the future. Take a read through the image language documentation to learn how to partly get around this limitation.

Preference File

# preferences.yml
options:
  source: /config/source/
  series: /config/yaml/sync_plex_seriestv.yml
  card_type: standard
  episode_data_source: plex
  image_source_priority: plex, tmdb
  filename_format: "{full_name} - S{season:02}E{episode:02} - {title}"
  validate_fonts: true
  season_folder_format: "Season {season:02}"
  sync_specials: true
  language_codes: 
  - fr
plex:
  url: http://xxxxxxx:xxxxxxx/
  verify_ssl: true
  token: xxxxxxxxxxxxx
  watched_style: unique
  unwatched_style: blur
  integrate_with_pmm_overlays: true
  integrate_with_kometa: true
  sync:
    file: /config/yaml/sync_plex_seriestv.yml
    card_directory: /config/cards
    library_name: Séries TV
    mode: match
    compact_mode: true
    add_template: global_template
tautulli:
  url: http://xxxxxx:xxxx/
  verify_ssl: true
  api_key: xxxxxxxxxxxxxxxx
  update_script: /tautulli/update_card.sh
  username: "xxxxx"
  agent_name: Update TitleCardMaker
  script_timeout: 120 
sonarr:
  url: http://xxxx:xxx/
  verify_ssl: true
  api_key: xxxxxxxxxxxxxxxxx
  # sync:
  # - card_directory: /config/cards/
    # downloaded_only: true
    # mode: match
  # - file: /config/yaml/sync_sonarr_seriestv.yml
    # add_template: global_template
tmdb:
  api_key: xxxxxxxxxxxxxxxx
  retry_count: 3
  logo_language_priority: fr

Series YAML

No response

Debug Log

[INFO] Read preference file "/config/preferences.yml" [CRITICAL] Invalid TMDb logo language codes - must be comma-separated list of any of the following: "ar", "ar-AE", "ar-SA", "bg", "ca", "cn-CN", "cs", "da", "de-AT", "de-CH", "de-DE", "el", "en", "es-ES", "es-MX", "fa", "fi", "fr-CA", "fr-FR", "he", "hi", "hu", "id", "it-IT", "it-CH", "ja", "ka", "ko", "lb", "lt", "lv", "my", "nb-NO", "nl-BE", "nl-NL", "nn-NO", "ms-BN", "ms-MY", "ms-SG", "no", "pl", "pt-BR", "pt-PT", "ro", "ru", "sk", "sr-RS", "sv-FI", "sv-SE", "th", "tr", "uk", "uz-UZ", "vi", "zh", "zh-CN", "zh-HK", "zh-SG" [CRITICAL] Preference file is invalid usermod: no changes [INFO] Read preference file "/config/preferences.yml" [CRITICAL] Invalid TMDb logo language codes - must be comma-separated list of any of the following: "ar", "ar-AE", "ar-SA", "bg", "ca", "cn-CN", "cs", "da", "de-AT", "de-CH", "de-DE", "el", "en", "es-ES", "es-MX", "fa", "fi", "fr-CA", "fr-FR", "he", "hi", "hu", "id", "it-IT", "it-CH", "ja", "ka", "ko", "lb", "lt", "lv", "my", "nb-NO", "nl-BE", "nl-NL", "nn-NO", "ms-BN", "ms-MY", "ms-SG", "no", "pl", "pt-BR", "pt-PT", "ro", "ru", "sk", "sr-RS", "sv-FI", "sv-SE", "th", "tr", "uk", "uz-UZ", "vi", "zh", "zh-CN", "zh-HK", "zh-SG" [CRITICAL] Preference file is invalid

CollinHeist commented 3 weeks ago

Transitioning to the fr-FR (or fr-CA) language code was intentional. Does specifying that instead of just fr work for your use?

Derekcde commented 3 weeks ago

no, I tried:

logo_language_priority: fr-FR logo_language_priority: 'fr-FR' logo_language_priority: "fr-FR"

CollinHeist commented 3 weeks ago

And what's the problem when you do that?

Edit: Never mind I see in your original post you said you get the same error. Let me look

CollinHeist commented 3 weeks ago

I just pushed a fix onto the develop branch, if you want to grab that and see if it works

Derekcde commented 3 weeks ago

Hi, it seems ok, I no longer have an error message with fr-FR do you know when it will be merged into the master branch?

CollinHeist commented 2 weeks ago

That's good. I would continue using fr-FR. That will likely not be merged into master for a while

Derekcde commented 2 weeks ago

ok, thank you for your answers 👍 , I close the issue