Closed update-freak closed 2 years ago
Thanks for the report, I will have a look into it upcoming week.
I upgraded the bpmn-js module as a pre-requisite step, as anyways the precedently used version is quite out of date. The newer bpmn-js features a promise based API and has a slightly different layer and bounding box API. I adapted the code but for today I have to give up further steps regarding checking the behavior on newer dokuwiki versions, I adapted on Greebo. Checks for Hogfather and Igor are pending.
I went through Greebo, Hogfather and finally Igor, the new version looks like working to me. Can you give it a try by upgrading to the latest version @update-freak ?
thanks for going through the different versions. I checked the Release Candidate (default selection when you try to download Dokuwiki) with included Web-Server. When I try to insert a process a got this appearance:
Could you please tell me which browser and which version you are using? I will try to reproduce that. I took the bare tarnall of dokuwiki with the plug-in in a php docker container so I think from the server perspective it is quite pristine. I suspect some client/ browser side issue.
sure. I used
An example is this one `<?xml version="1.0" encoding="UTF-8"?>
Thanks for the details!
I have now:
Installed extensions
Used your xml surrounding it with
<bpmnio zoom=1.0>
... your xml here
</bpmnio>
Test Beispiel 1
And get as a result:
Which looks ok to me...
Ahhhhh I finally got it reproduced after deleting all the cache folders...
Working on it. (This makes me believe the tests I performed were bogus :-/ due to the cached files, hmmm)
I think for sure this has to do with the deferred loading of the js assets
I think I could find a part of the problem, the dokuwiki svg style: https://github.com/splitbrain/dokuwiki/issues/3690
Thanks to the hint regarding the proper use of css (🤦🏻♂️ ) I could manage to bring in a first working version for Igor. Thanks a bunch for your patience. I hope I got it now, could you please give it another try?
Thank you very much!! I can confirm that it works (rendering is good)
One thing i found is that for large processes or small screens (see screenshot) the process is not fully displayed and there is no possibility to scroll to the rest of the process. It would be great if you could add that function. I think with the old version this was also possible.
True I will do that within the next days... Sorry to have broken that feature, I reworked the plugin fully after having read the documentation on how it should be.... Another thing is that the old version also had some kind of overlay to show what is "selected" on the diagram. It looks like the newer bpmnjs version handles that differently. I have started also reading about this, but this week I am running out of free time for that I fear.
@update-freak I could arrange to get a state where the bpmn is rendered using 100% of the space available and if it is bigger then display a scrollbar. I think this is nice to have the BPMN.iO Logo aligned to the right instead of a messier look.
If you are ok with the results now, feel free to close the ticket.
Yes, I can confirm that the scrollbar is working as exspected. Now I'm very happy with the result :) Thank you for your effort and the quick solution!!
Hello after updating to version rc2022-06-26 "Igor" RC2 I noticed that the visualisation is strange (see testprocess). I downloaded the version with MicroApache for testing (old and new version (RC) of DokuWiki). Please fix this problem with the new DokuWiki release