search

Color-Of-Code / dokuwiki-plugin-bpmnio

Renders BPMN and DMN diagrams using the bpmn.io js library within dokuwiki
https://www.dokuwiki.org/plugin:bpmnio
Other
1 stars 2 forks source link

Editor support #5

Closed andyboeh closed 2 years ago

andyboeh commented 8 years ago

This adds initial support for an editor component. I did quite some changes to your code:

The editor works similarly to "edittable": You get a sall "Edit" icon beneath the diagram and, once you click it, you can edit just this diagram. The formatted, changed XML saved back to the Wiki page.

What's missing, but would be nice, is a tool bar button that adds this default content.

andyboeh commented 8 years ago

I had to partially revert action/viewer.php as DokuWiki's minifier can't minify the original bpmnio version properly. I also updated it to v0.15.1

jdehaan commented 8 years ago

Thanks for the contribution. I've been on vacation a couple of weeks and now I have a quite high stack of tasks to get rid of. As the code is used in production I need to carefully review and check the code. Please be patient. Best regards.

juliusstoerrle commented 5 years ago

As an administrator I would like to disable editing either page wide and/or overwrite the global setting with an attribute on the tag. Having the editor enabled will probably result in different versions of processes in my organization.

(Otherwise I like that an editor is there if you need it)

jdehaan commented 5 years ago

Thanks for the comment! I plan to add the editor alike the table editor for example. The plugin would not bypass normal page rules, that means people without write rights won't be able to change things. But you are right, if the editor is too easily accessible someone might inadvertently modify things. Maybe adding an optional flag like read-only to the options will mute the editor. I think that is a good idea.

adam52 commented 3 years ago

Wow, this sounds fantastic! I would love to see this merged into the main branch. Is this still being actioned?

jdehaan commented 3 years ago

The current state needs to be adapted to the current master to get mergeable. As our flow involves using an external editor and are only interested in the viewer I do not have much time to make this fit test and maintain it. I definitively would merge a clean patch if it is implemented as opt-in.

jdehaan commented 2 years ago

Closing as obsoleted by #32