Inconsistent usage of _default_config and default_config in config.py

ColoradoSchoolOfMines / visplay

A libmpv and Qt based application for automating and controlling media playback on any display.

https://coloradoschoolofmines.github.io/visplay/

GNU General Public License v3.0

4 stars 1 forks source link

Inconsistent usage of _default_config and default_config in config.py #32

Open robozman opened 6 years ago

robozman commented 6 years ago

In config.py we declare default_config = path.join(_config_folder, 'config.yaml' and then proceed to use cls._default_config everywhere else. I've encountered this issue while porting to Windows. Is this just a typo or does it work on Linux for some reason. @jhgarner, @sumnerevans

sumnerevans commented 6 years ago

All instances of _default_config should be default_config. The default_config member is public (it is used in __main__:52), but it also is used in config.py:92,93,95.