ColorfulSoft / DeOldify.NET

C# implementation of Jason Antic's DeOldify
Apache License 2.0
297 stars 57 forks source link

DeOldify on macOS #14

Open TheVincinator opened 2 years ago

TheVincinator commented 2 years ago

Hi! Are you guys planning to make a DeOldify app for macOS? It would be great if you guys could. Thanks!

GlebSBrykin commented 2 years ago

Hello! Theoretically, you can use the Linux version on macOS. You need to follow the official instructions for installing mono on macOS: https://www.mono-project.com/download/stable/#download-mac . Then follow the instructions for Linux from the DeOldify.NET repository. You should start with the "Download sources" item. If you manage to run the application on mac OS, leave a review and a description of what you did and I will add this information to the repository.

lextm commented 2 years ago

A cross platform UI framework (Avalonia, MAUI, or Uno) should have been used. WinForms on Mono (Linux/macOS) is obsolete.

GlebSBrykin commented 2 years ago

Despite the obsolescence of WinForms, the technology is supported by Windows, Linux and macOS and will not cease to be available for use in the foreseeable future. The main goal of the project is to use a minimum number of components and dependencies to minimize possible incompatibility problems and simplify installation and use DeOldify.NET to the limit. Using something from what you have suggested, for example, will radically complicate the compilation and launch of the application on Windows. Now on Windows you can build and use DeOldify.NET, using pre-installed Microsoft .NET Framework, however, the use of the proposed frameworks for GUI implementation deprives this possibility.

lextm commented 2 years ago

@GlebSBrykin in case you don't know, ever since macOS becomes 64 bit only, there isn't WinForms on macOS any more. That's why this issue was opened (I guess you don't have a Mac right now).

To really catch up with the modern .NET evolution, you should stop relying on .NET Framework/Mono and only use things like .NET 6. You are showing people how to use modern technologies like deep learning, so you should also avoid obsolete things.

GlebSBrykin commented 2 years ago

Perhaps you are right. I can't talk with confidence about mac OS, since I've never worked with it. I get all the information from my colleagues. As for newer GUI frameworks, they will definitely be used in the future. In one of the issues , I talked about long - term plans to migrate the code to .NET 5 or .NET 6 in order to improve performance by using vector processor instructions. When I work on this, then I will implement a new interface.