Closed Colorfulstan closed 6 years ago
Colorfulstan
commented
6 years ago https://github.com/Colorfulstan/LeagueJS/tree/DataDragonHelper contains a first iteration of DataDragon integration.
Found on npm as leaguejs@beta https://www.npmjs.com/package/leaguejs/v/1.10.0-beta.1
Colorfulstan
commented
6 years ago Release candidate: https://www.npmjs.com/package/leaguejs/v/1.10.0-beta.8
Testing it in my projects and when nothing else comes up will squash/rebase into master for 1.10.0
Old Code should not be effected, but returned properties from gettingChampions will differ and might break some edge cases. Tags will have no effect anymore, unless used with gettingChampions (to either get the smaller champion.json or championFull.json file).
Colorfulstan
commented
6 years ago 
WeihengLu
commented
5 years ago New to data dragon, for getting static data like "Jax W spell scale with XX ad ratio", so I just use URL like "http://ddragon.leagueoflegends.com/cdn/6.5.1/data/en_US/champion/Jax.json" to get the JSON and extract and look at the ad ratio in JSON manually?
Colorfulstan
commented
5 years ago Sorry for being late...
Doesn't look like an Issue with the Library but with the data you get. But your general idea is correct, you get the respective json file (note the version in the url!) and get the static data from there.
You'll be able to find help on the RIOT Api developers Discord more easily then in the issues here :) https://discord.gg/riotapi
https://discussion.developer.riotgames.com/articles/5719/removal-of-the-lol-static-data-v3-api.html
August 27th Static Data endpoints will be removed.
I'm in the process of adding DataDragon support, but not sure if I will get to rewire all the methods in time.
Simply delivering the DataDragon files through the endpoint methods would be a good first step to prevent a breaking change, but adding the options back in might be a pain, and possibly not worth the effort.
Open for discussion and contribution, will update here when the DataDragon integration is live.