search

Colorfulstan / LeagueJS

A Javascript Wrapper for the League of Legends API
MIT License
99 stars 7 forks source link

Added Challenges endpoints #30

Closed cloeys closed 2 years ago

cloeys commented 2 years ago

Hello,

These commits add methods for the challenges endpoint (lol-challenges-v1) of the Riot API. I wanted to do build something with these endpoints and didn't find a package which implemented a wrapper for it yet, so tried my hand to extend your wrapper with it. closes #31

Note, this is my first public pull request ever and although I did my best to conform to your coding standards, I am aware there might be inconsistencies, so feel free to point them out and correct, or I will correct it. I am also not an expert in testing, let alone testing in JS, so please excuse me if the tests aren't up to par. :-)

Any other remark or feedback, I'll gladly hear it.

Kind regards, Christophe

Colorfulstan commented 2 years ago

Hi there :)

Thanks for your contribution! Looks great and I'm glad that this project motivated you to practice some things.

I will merge and make a new minor release 👍

Only remark I can give you is to look into commit message formatting. I usually go with the Angular commit message theme, as I find that most helpful to communicate changes efficiently: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit

You can find that in action in a semi-consistent manner on my git history in the project. But that's just an opinionated Tip, not a critic.

Colorfulstan commented 2 years ago

published as 2.3.0