Colorfulstan / LeagueJS

A Javascript Wrapper for the League of Legends API
MIT License
99 stars 7 forks source link

Deprecation of LeagueEndpoint.gettingLeagueBySummonerId #4

Closed Colorfulstan closed 7 years ago

Colorfulstan commented 7 years ago

https://discussion.developer.riotgames.com/articles/3677/the-deprecation-of-the-league-v3getallleaguesforsu.html

Endpoint will be removed on January 10th

Since the breaking change is not imposed by the library and since the endpoint will stop working within the old versions anyways, versioning will propably stay on 1.x

ferderber commented 7 years ago

I'm interested in helping out for this.

I don't think leagueId is a Constant. It's similar to SummonerId or AccountId (it's a UUID).