search

Colorfulstan / LeagueJS

A Javascript Wrapper for the League of Legends API
MIT License
99 stars 7 forks source link

Add gettingLeagueById to League endpoint #5

Closed ferderber closed 7 years ago

ferderber commented 7 years ago

This PR adds the implementation for gettingLeagueById, a basic test, and test data.

Note: At the time of writing this, the EUW1 version of the League endpoint is not functioning. The NA1 API seems to be working fine so that's where I chose the test data from.

Let me know if there's anything missing.

Colorfulstan commented 7 years ago

Cool, thanks!

I was thinking to add a console.warn() to the deprecated method, that it will be removed on January 10th + the same note on the @ deprecated tag.