search

ColorlibHQ / AdminLTE

AdminLTE - Free admin dashboard template based on Bootstrap 5
https://adminlte.io
MIT License
44.06k stars 18.16k forks source link

fastclick is not working (300ms delay) #688

Closed iamgoodbytes closed 9 years ago

iamgoodbytes commented 9 years ago

Hi! First of all I want to thank @almasaeed2010 for the fantastic template and for sharing it with us.

I ran into an issue where fastclick isn't loading with a 300ms delay as a result. I've logged the issue with FastClick, but it's probably an issue with AdminLTE: https://github.com/ftlabs/fastclick/issues/409#issuecomment-141074229

You can try it out by going to adminLTE preview on an iphone and navigate through the menu. You'll notice a 300ms delay when clicking around menu items.

Any idea what can be the issue here?

almasaeed2010 commented 9 years ago

I see the issue you are talking about. I've always doubted whether it was actually working or not. Could it be because we are attaching the Fastclick listener too soon? I am not sure I really understand how the script work at the moment but I remember it working better when I first implemented it. I think we need to reconsider using the script if it isn't doing what its supposed to. I will look into this further when I get a chance.

I apologize for the delay, too many school related projects at the time. I appreciate the compliments!

Thanks!

iamgoodbytes commented 9 years ago

Hi Abdullah! Thanks for taking the time to respond. My guess is indeed that the screen is being attached before the content is fully loaded. Fastclick itself works fine, I've used in in several other projects.