search

ColorlibHQ / illdy

Illdy is a free one page WordPress business theme with a minimal design
GNU General Public License v3.0
44 stars 38 forks source link

[Enchancement] Basic HTML support for Widgets #185

Closed laranz closed 7 years ago

laranz commented 7 years ago

We need to give the users to use some basic HTML like bold, italic, br tag, etc., for our illdy widgets.

Reported on: https://colorlib.com/wp/forums/topic/force-a-non-breaking-space-in-the-widgets/

cristianraiber commented 7 years ago

@giucu91 - we should be using wp_kses_post to sanitize output here.

cristianraiber commented 7 years ago

@laranz - please pull the latest version of Illdy from here: https://github.com/MachoThemes/illdy && https://github.com/MachoThemes/illdy-companion and test to make sure this has been implemented correctly.

Please report back your findings in this ticket so we can close/update it after testing.

cristianraiber commented 7 years ago

@laranz - can you please pull the updates now? It should be fixed.

Thanks, Cristian.

laranz commented 7 years ago

Hi,

I found two issues, other than that all looks just fine.

  1. The links isn't live Preview like the bold and italic.

image

  1. For Services and Team section, we didn't enable the HTML?

Regards,

cristianraiber commented 7 years ago

@giucu91 - please see this.

giucu91 commented 7 years ago

Hello @laranz ,

Can you please tell me more about 1, because I can't reproduce it. About the second issue, we have HTML enabled for services & team. What have you tried to use and is not working ?

cristianraiber commented 7 years ago

@laranz - any news re. this? I was hoping to release an update this week.

laranz commented 7 years ago

Hi,

  1. Latest repo fixed this.
  2. We have HTML enabled for those, but it don't have a WP Editor like the Parallax widget has. We need to add the HTML by our own. If we have WP Editor like Parallax widget means, it is easy.

Regards,

cristianraiber commented 7 years ago

@giucu91 - I think what @laranz is trying to say is that the "Parallax widget" currently has a textarea instead of a WYSIWYG editor. The users have to write the HTML by hand, instead of using TinyMCE shortcuts, such as: bold, italic, underline, etc.

However, since we've worked a lot on this release, I'll be postponing this feature for a future release.