ColorlibHQ / illdy

Illdy is a free one page WordPress business theme with a minimal design
GNU General Public License v3.0
44 stars 38 forks source link

Conflict between Polylang and Randomising uploaded headers #239

Closed a-support closed 6 years ago

a-support commented 7 years ago

https://colorlib.com/wp/forums/topic/conflict-between-polylang-and-randomising-uploaded-headers/ I recently installed the plugin Polylang and I can see that it interferes with the Randomising uploaded headers functionality in the Customising ▸ Blog Options ▸ Blog Archive Header Image section of the theme, not uploading any images at all. If I select a single image (not randomising) it works fine, but otherwise, the functionality stops working in all blog pages.

You can see that there is no address in the url when inspecting with the javascript console: <header id=”header” class=”header-blog” style=”background-image: url( );background-attachment: fixed;”>… Here is the link to where the conflict is happening in my website: https://www.myhktutors.com/student-registration/

Is there anyway to get this feature working while using Polylang?

cristianraiber commented 6 years ago

@a-support - I'll look into this.

cristianraiber commented 6 years ago

@a-support - I've just tested this and it's working absolutely fine with Polylang installed.

❗️ ❗️ What I believe happened is a small confusion. You can randomize suggested headers and/or uploaded headers. There's no way to randomise between uploaded & suggested (mix the two images together). To that end, you need to have multiple images uploaded before the randomisation feature actually starts working as intended.

Here's how it currently looks at my end:

image

ℹ️ As you can see, the "Current header" upload field currently states "Randomizing uploaded headers". This feature works as intended, with Polylang installed & 2 languages added (it that matters, but I doubt).

This is a core WordPress functionality and if Polylang broke it at some point, it was up to them to fix it.

☮️ Will be closing this as it seems to me invalid. Of course, feel free to open it up again if you believe this still happens or it was closed by mistake.

Thank you.