ColorlibHQ / illdy

Illdy is a free one page WordPress business theme with a minimal design
GNU General Public License v3.0
44 stars 38 forks source link

Add fallback image for jumbotron featured image #5

Closed FreeWPTP closed 7 years ago

FreeWPTP commented 8 years ago

When Jumbotron is set to use featured images, it would be very helpful to fall back to the default image from home.

Use case: I set “Featured image as jumbotron” in customizer and then forget to set a featured image for a post/page. Currently I get a white background, which is unpleasant, as the jumbotron is also white.

Solution: Simply add

} else {
        $style = 'background-image: url(' . esc_url( $jumbotron_general_image ) . ');';
    }

in header.php on line 29.

Related topic :

https://wordpress.org/support/topic/add-fallback-image-for-jumbotron-featured-image/

iwanikhalid commented 7 years ago

Personally I think post/page header images should fallback to Blog Archive Header Image which what the developer had done.

I don't usually want my frontpage header to be the same as innerpages header