search

ColtonProvias / sqlalchemy-jsonapi

JSONAPI implementation for use with SQLAlchemy
MIT License
71 stars 27 forks source link

Incomplete support for SQLAlchemy types #23

Open jimbobhickville opened 8 years ago

jimbobhickville commented 8 years ago

Running into this error with a postgres numeric type which leverages decimal.Decimal under the hood:

TypeError: Decimal('1.6') is not JSON serializable

I think I see how to add it, so I'll put up a PR if I'm successful.

jimbobhickville commented 8 years ago

So I have a fix, but I had to go back a dozen commits or so to find a commit that wasn't broken to branch from. Any chance you can put the unfinished stuff into a separate branch and get master back in a clean state so I can submit a proper PR and get this fix released?

ColtonProvias commented 8 years ago

I just branched the 4.x.x branch off so you can submit the fix to there.

jimbobhickville commented 8 years ago

Thanks, I'll update my branch and get a PR up later tonight.

jimbobhickville commented 8 years ago

Ok, it ended up being a few days before I could get to it, but PR is up now.

vilka95 commented 6 years ago

I have a similar issue with Data type. any advice on how to handle that, please?