Create new unittests (one test), nose to execute, and add code coverage

ColtonProvias / sqlalchemy-jsonapi

JSONAPI implementation for use with SQLAlchemy

MIT License

70 stars 27 forks source link

Create new unittests (one test), nose to execute, and add code coverage #37

Closed kaitj91 closed 7 years ago

kaitj91 commented 7 years ago

This PR does the following:

Create new unittest folder and adds a single unit test using unittest.
Updates tox.ini to call nosetests on the new unittests folder.
Provides code coverage over the newly added unittest

The new unittest added gave an overall test coverage of 35%.

Anderycks commented 7 years ago

We need to get tests passing first before I can look at the patch.

kaitj91 commented 7 years ago

I forgot to update TravisCI. Will add tests to that and get those running. I only updated the tox.ini file.

kaitj91 commented 7 years ago

After talking with deryckh I will make these unittests using the sqlalchemy db and not using the flask app, since the test is only testing the serializer which only needs a db.session. I will close this PR and put a new one with changes discussed.