search

ColtonProvias / sqlalchemy-jsonapi

JSONAPI implementation for use with SQLAlchemy
MIT License
70 stars 27 forks source link

Make it possible to get at __version__ within code #65

Closed Anderycks closed 7 years ago

Anderycks commented 7 years ago

This is a back port of something that was in the 5.0 code that all had to be reverted. I was maintaining this in a fork branch for use within Isilon, but now that I can get changes into master here, I'd like to merge this and throw away my fork.

There's a nasty XXX within setup.py though. I have no idea how to fix this since we dynamically install enum34 and import literally everything into __init__.py. I'd prefer we didn't import everything into the top-level namespace but this will break backwards compatibility. So I guess this hack needs to stay around until we stop supporting Python 2.7.

The upshot of this XXX is that you have to change the version string in two places when rolling a release.

rockstar commented 7 years ago

LOLOLOLOLOLOLOLOLOLOLOLOLOLOLOLOLOLOLOLOLOLOLOLOOLOLOLOLOLOLOLOLOLOL

👍

kaitj91 commented 7 years ago

Sorry took some time Deryck. Looks good and so happy I don't have to have hard coded test versions now :)