Coly010 / ng-rspack-build

Rspack plugin and loaders to build Angular applications

40 stars 5 forks source link

fix(build): renamed option key to _option #26

Closed swalker326 closed 3 weeks ago

swalker326 commented 3 weeks ago

Description

This PR updates the NgRspackModuleFederationPlugin to standardize the attribute name from options to _options, aligning it with the naming conventions used in other Module Federation plugins. This change resolves the inconsistency and improves compatibility across plugins.

Changes

Renamed options to _options throughout the plugin configuration. Updated all references to use _options instead of options. This update should improve interoperability for users who rely on a consistent API structure across Module Federation plugins.

Closes #25

zmzlois commented 3 weeks ago

this awesome, should we dm Column?

Coly010 commented 3 weeks ago

If we're doing this for consistency can we also update the other Plugins in the build package? https://github.com/Coly010/ng-rspack-build/blob/main/packages/build/src/lib/plugins/ng-rspack.ts

https://github.com/Coly010/ng-rspack-build/blob/main/packages/build/src/lib/plugins/module-federation/ng-rspack-module-federation-dev-server-plugin.ts

swalker326 commented 3 weeks ago

Think I got them all

nx-cloud[bot] commented 3 weeks ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6362a41d2724f9b578247bb39ede6f73a7016ef1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

- [`nx affected -t lint test build integration`](https://cloud.nx.app/runs/i9KZFpnt4V?utm_source=pull-request&utm_medium=comment) - [`nx-cloud record -- pnpm check-commit`](https://cloud.nx.app/runs/cPdd5uC5Xc?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.