Move definitions from FailsafeScenarios.cpp to proper header files

[lilooraf]

Can I get more informations? The definitions are in the cpp like supposed, do you want a FailsafeScenarios header with the declarations? Sorry for my incomprehension.

[JanWielgus]

Sorry. That is my fault. I made this issue very fast and described it just that I know what should be done. The issue concern src/Failsafe/ folder. What is done is the following: There are several header files for specific FailsafeScenarios and FailsafeActions with declarations, but their definitions are now in one shared cpp file (For FailsafeScenarios this is FailsafeScenarios.cpp and for FailsafeActions this is FailsafeActions.cpp).

Those classes are very simple. I think that it will be sufficient to implement them without cpp files and move definitions to proper header files. For example move all implementation (definitions of methods) of TiltExceeding class from FailsafeScenarios.cpp to TiltExceeding.h (just when they are declared in a class). The same with CommunicationLost class. In the end FailsafeScenarios.cpp file should be empty, so delete it. Similar thing is with DisarmMotors.h and FailsafeActions.cpp (move definitions from the latter to the former and delete the latter).

Feel free to ask if something is still confusing.