ComArmor / comarmor

Like AppArmor, but for Secure Communications
Apache License 2.0
0 stars 1 forks source link

Topic Access Rule #4

Open ruffsl opened 7 years ago

ruffsl commented 7 years ago

To begin with one of initial rule types proposed in https://github.com/ComArmor/comarmor/issues/1 , an access rule for topics should be defined. Given a generalized pub sub architecture, topic rule should encapsulate a basic set of primitive attributes, including:

ruffsl commented 7 years ago

The current approach developed for for topics as described using the nomenclature defined in https://github.com/ComArmor/comarmor/issues/1:

Topic Access Rule style

ComArmor 0.0.1
  <rule qualifier> ::= [('audit'|'quiet')] [('allow'|'deny')]
  <topic rule> ::= [<qualifiers>] 'topic' <path> <permissions> ','
<permission> ::= <short form>
<short form> ::= [spr]+

Short form permissions:

Topic access rules are denoted with the necessary keyword topic, and can be prefix with a number of rule qualifier. Topic rules must specify the topic namespace as the path, as well as the permission to effect. The permissions are appended masks that can be combined to control more than one per permission per line.

The rule style here borrows heavily from AppArmor's File Access Rules, but differs in a few key aspects. The same basic set of qualifier are supported, as is currently intended for most ComArmor rules. This includes an audit qualifier to set the specific rule in audit mode, a quiet qualifier to silence a rule if the parent profile is set to audit mode, an allow qualifier that is currently optional as it is implied with the omission of thedeny qualifier, with deny overriding any scope of applicable allow rule elsewhere.

A primary departure from the File Access Rule is the stricter structure of the rule syntax. The first being that the ordering of permissions and topic path can not be reversed.

The second being is with the topic keyword being required. This prevents an implied default rule type with the absence of the keyword, as is the case in AppArmor. This also simplifies a lot of the parsing and serialization logic used when maintaining a consistent format during automated modifications.

Thirdly, topic rules can't be 'bare', i.e. they can not be void of a path or permissions. This is in contrast with is possible for a file rule in apparmor, where a base rule can be used to globally give or revoke access to all files. Personally, I find this kind of implicit wildcard is a little dangerous; as say if someone leaves a half finished topic rule with a trailing comma while editing and never notices upon revisiting. The rule format topic /** psr seem much more alarming in severity that an innocent topic,. But such shorthand does have its benefits, e.g denying all topic access via deny topic,, so this could change.

I briefly considered following a rule style more closly to that of AppArmor's Network Rules, as ComArrmor is more comuncation network orendated. In the end though I figured it perhaps needlessly verbose, with many of the semantic arguments lacking a direct corresponding attribute for general topic rules.