search

ComPWA / compwa.github.io

Source code for the ComPWA Organization website
https://compwa.github.io
Apache License 2.0
5 stars 4 forks source link

DOC: add reports about T-matrix Riemann sheets #204

Closed redeboer closed 7 months ago

redeboer commented 1 year ago

Moved to #261

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

redeboer commented 1 year ago

The documentation jobs have been killed due to timeout https://readthedocs.org/projects/compwa-org/builds/22004094/ https://github.com/ComPWA/compwa-org/actions/runs/6275813340/job/17044140980?pr=204 I've tried running this PR locally as well and it seems to have to do with the combination of widgets with plotly. @Zeyna777, could you remove the widgets and keep the plotly to see if this fixes the CI? We can then see if plotly renders at all and revert to the widgets when we find the cause of the problem.

redeboer commented 1 year ago

I'm wondering whether we should merge this TR into the existing TR-004, which is an investigation into analyticity that has not been finished 🤔

redeboer commented 11 months ago

Hi @Zeyna777 thanks for the updates! The diff of 5f36a6a is huge, because nbstripout was not run. Can you

  1. install the pre-commit hooks so that the notebook output is removed before committing? 
    pre-commit install --install-hooks
  2. (alternatively) run nbstripout specifically before you commit and push 
    pre-commit run nbstripout -a

In the end, pre-commit.ci actually does all the fixes for you through the PR (see 79f9b27), but doing this locally makes it easier to see what changes have been made to the code.

redeboer commented 7 months ago

@Zeyna777 the temporary notebooks have been removed. You can retrieve them from 36c1c467 with

git checkout 36c1c467

and move them somewhere else.