ComPWA / compwa.github.io

Source code for the ComPWA Organization website
https://compwa.github.io
Apache License 2.0
5 stars 4 forks source link

DX: identify unidentified variables in notebooks #223

Closed redeboer closed 9 months ago

redeboer commented 9 months ago

Ruff was ignoring F821 in Jupyter notebooks. This is not a good idea, because one often makes typos and then only realizes that a variable name is mistyped only once the notebook is run. Now, typos in variable names are flagged.

The reason for ignoring F821 is that cell magic sometimes makes it look like a variable is not defined, which resulted in many false-positives. There is no good solution for this, so the error is now ignored for specific notebooks.

review-notebook-app[bot] commented 9 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB