search

ComPWA / compwa.github.io

Source code for the ComPWA Organization website
https://compwa.github.io
Apache License 2.0
5 stars 4 forks source link

DOC: build amplitude with K-matrix dynamics #278

Closed Zeyna777 closed 3 months ago

Zeyna777 commented 3 months ago

Imported some more notebooks from https://github.com/ComPWA/K-matrix-research/pull/72. See also https://github.com/ComPWA/compwa.github.io/pull/261.

Notebook Topic
TR-030 Sub-intensity plots and phases
TR-031 Fit comparison P vector and Breit–Wigner
TR-032 Coupled P vector fit 
### To do
- [x] Gererate data with F vector instead of Breit-Wigner
- [x] Generalize N** (fakestar) naming
- [x] Define two fakestars through Python, not YAML
- [x] Reorder reports (plots first, fits after)
- [x] Speed up histogramming with JAX
- [x] Avoid overwriting `m_1` etc. in parameters for coupled fit
- [x] Clean up **TR-032**
- [x] Parameters in **TR-032** should recreate Flatté https://github.com/ComPWA/compwa.github.io/pull/278#issuecomment-2127302822
review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

redeboer commented 3 months ago

7e949de...c658bd1 introduces a behavioural change (bug?)

7e949de

389fa2d106d76fdc29a6cdcd12ca38a69d5e886a3883ae1858bfe79746b8cbb0

c658bd1

97a5701f0823698cdbc3755f01bfffee3f7f9f138015b53d5078b5959b161302

Zeyna777 commented 3 months ago

Pullrequest man

Generated in Toyfits_DataFVector_MoreChannel.ipynb, 71c5e3f39009e3e64c188562f286a4702b83a65e

redeboer commented 3 months ago

https://github.com/ComPWA/compwa.github.io/pull/278#issuecomment-2126984822

After rebasing and splitting some commits, it turns out that the $g$ couplings were also set to zero in the sub-intensity functions. This is fixed in c60758b31df4dfc0674aecca60aaef200f89bb6e.