Closed redeboer closed 3 years ago
redeboer
commented
3 years ago expertsystem 0.7.2 should be released first, because this is a major change to the interface.
In addition, note that at this stage it starts to make more sense to split the expertsystem into some pwa-reaction and pwa-amplitude package. This can be easily done now that io only operates on classes from the reaction module.
codecov[bot]
commented
3 years ago Merging #551 (2d954cc) into master (f21f974) will not change coverage. The diff coverage is
100.00%.
@@ Coverage Diff @@
## master #551 +/- ##
=======================================
Coverage 86.33% 86.33%
=======================================
Files 22 22
Lines 3636 3636
Branches 885 885
=======================================
Hits 3139 3139
Misses 320 320
Partials 177 177 | Flag | Coverage Δ | |
|---|---|---|
| unittests | 86.33% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/expertsystem/reaction/particle.py | 93.92% <ø> (ø) |
|
| src/expertsystem/__init__.py | 100.00% <100.00%> (ø) |
|
| src/expertsystem/amplitude/_graph_info.py | 81.96% <100.00%> (ø) |
|
| src/expertsystem/amplitude/dynamics/builder.py | 46.42% <100.00%> (ø) |
|
| src/expertsystem/amplitude/helicity.py | 86.29% <100.00%> (ø) |
|
| src/expertsystem/amplitude/kinematics.py | 84.21% <100.00%> (ø) |
|
| src/expertsystem/io/__init__.py | 88.09% <100.00%> (ø) |
|
| src/expertsystem/io/_dict.py | 91.76% <100.00%> (ø) |
|
| src/expertsystem/io/_dot.py | 75.88% <100.00%> (ø) |
|
| src/expertsystem/reaction/__init__.py | 83.05% <100.00%> (ø) |
|
| ... and 5 more |
The
particlemodule was originally under a separate module, because it could theoretically operate on its own. However, since its main classesParticle,ParticleCollectionandSpinmerely serve as user interfaces to thereactionmodule, it's better to move it back into thereactionmodule.This PR also enables #372, which was currently not possible due to cyclic imports.