search

ComPWA / expertsystem

Rule based particle reaction problem solver on a quantum number level
http://expertsystem.rtfd.io
1 stars 3 forks source link

refactor: use GellMann-Nishijima rule in particle mod #552

Closed redeboer closed 3 years ago

redeboer commented 3 years ago

Closes #372

redeboer commented 3 years ago

@spflueger Seems to work, only the tests fail because there's something wrong with the way the rule is used in the post init check of Particle.

codecov[bot] commented 3 years ago

Codecov Report

Merging #552 (3d13ff8) into master (e7fc5ab) will decrease coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
- Coverage   86.27%   86.23%   -0.05%     
==========================================
  Files          22       22              
  Lines        3636     3625      -11     
  Branches      885      884       -1     
==========================================
- Hits         3137     3126      -11     
  Misses        321      321              
  Partials      178      178
Flag Coverage Δ
unittests 86.23% <100.00%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expertsystem/amplitude/_graph_info.py 81.96% <100.00%> (ø)
src/expertsystem/amplitude/helicity.py 85.62% <100.00%> (-0.05%) :arrow_down:
src/expertsystem/amplitude/kinematics.py 84.09% <100.00%> (-0.12%) :arrow_down:
src/expertsystem/reaction/__init__.py 83.05% <100.00%> (ø)
src/expertsystem/reaction/_system_control.py 89.72% <100.00%> (ø)
src/expertsystem/reaction/combinatorics.py 90.79% <100.00%> (-0.19%) :arrow_down:
src/expertsystem/reaction/conservation_rules.py 92.12% <100.00%> (-0.03%) :arrow_down:
src/expertsystem/reaction/particle.py 93.22% <100.00%> (-0.71%) :arrow_down:
src/expertsystem/reaction/quantum_numbers.py 100.00% <100.00%> (ø)