search

ComPWA / tensorwaves

Python fitter package for multiple computational back-ends
https://tensorwaves.rtfd.io
Apache License 2.0
10 stars 4 forks source link

Isolate recipe-related builder functions #102

Closed redeboer closed 3 years ago

redeboer commented 4 years ago

Currently, dictionary keys that depend one the recipe file structure are spreading through the framework. So each time the recipe structure changes, we need to go through the rest of the framework to modify those strings. See e.g. #95.

A first step would be to isolate all builder functionality (e.g. IntensityBuilder) to a seperate module, as long as they are dependent on a recipe format.

Related to https://github.com/ComPWA/expertsystem/issues/22

spflueger commented 4 years ago

In tensorwaves there is only only the builder which depends on this recipe structure. I don't think this can be improved further until we introduce the recipe class in the expert system as an interface.

redeboer commented 4 years ago

In tensorwaves there is only only the builder which depends on this recipe structure. I don't think this can be improved further until we introduce the recipe class in the expert system as an interface.

That's correct, https://github.com/ComPWA/expertsystem/issues/22 has to be fixed first, but that's a bigger project