fix: dataset thumbnail image to match magnified preview when annotated

FabianMauz commented 2 weeks ago

This PR fixes the problem that in an container image preview the thumbnail image does not match the magnified image if the user clicks on it if there is an annotated version of the image (see #1927).

It also fixes that for cell lines the magnify function was not enabled.

As discussed with the reviewer the fix does not fully solve the problem. After annotating the image in the container the preview image is instantly updated but the magnified image still needs a reload of the element. It would need a relative big refactoring of the logic to achieve an instant updating. Since there is an issue that requires this modificationanyway, I would like to plead in favor of solving this remaining problem in issue https://github.com/ComPlat/chemotion_ELN/issues/1928

github-actions[bot] commented 2 weeks ago

LCOV of commit `0e34bd0` during Continuous Integration #2981

Summary coverage rate:
  lines......: 64.1% (13672 of 21316 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

FabianMauz commented 1 week ago

After some discussion with @PiTrem we decide to also check, if the problem of magnifying the preview in direct attachments is also related to the same problem and if it easy to solve.

FabianMauz commented 1 week ago

The fix above solves partially the issue with attachment annotated previews. The preview will only be correct if the side was reloaded. Again a rework would be needed to solve it completely. This will be done in https://github.com/ComPlat/chemotion_ELN/issues/1928

github-actions[bot] commented 1 week ago

LCOV of commit `8ec13da` during Continuous Integration #3005

Summary coverage rate:
  lines......: 64.1% (13672 of 21316 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

ComPlat / chemotion_ELN