search

ComPlat / chemotion_ELN

Electronic Lab Notebook
https://www.chemotion.net
GNU Affero General Public License v3.0
125 stars 51 forks source link

TLC plate image upload in properties tab #565

Open AnnettNFDI opened 3 years ago

AnnettNFDI commented 3 years ago

As a user I wish to upload and display a TLC plate image directly in the properties tab in the reactions element as there are also documented the information on TLC plate conditions.

nicolejung commented 3 years ago

The TLC image should be part of the analytics -> the ontology exists already and can be used, also image upload exists.

Screenshot (1648)

One should insert the TLC analysis with the reaction if the TLC is used as reaction control. If it's used as method to check the purity, then an assignment to the sample is suitable

AnnettNFDI commented 3 years ago

Ok. Yes, I understand. That is logical. However, at the samples element there are no TLC fields to document solvent, rf-value etc, as available in the properties tab in reactions.

nicolejung commented 2 years ago

We created #572: it is almost finished. If you agree, I will close this issue?

AnnettNFDI commented 2 years ago

Yes, it is fine to close the issue.

adambasha0 commented 2 years ago

Video for tlc section in sample properties

https://user-images.githubusercontent.com/55552142/151383141-d8514e17-a166-4fec-9864-77041ef9609a.mp4

AnnettNFDI commented 2 years ago

Unfortunately, the video is not displayed. I get an error message, that the file is damaged.

adambasha0 commented 2 years ago

are you sure? it works for me!

AnnettNFDI commented 2 years ago

grafik

AnnettNFDI commented 2 years ago

Seems to be a browser thing. Switching to chrome solved the problem. Sorry, my mistake ;). Now it works!

adambasha0 commented 2 years ago

ok great

adambasha0 commented 2 years ago

also updates on tlc section in reaction properties page. User can update tlc values from reaction property as well as sample property.

https://user-images.githubusercontent.com/55552142/151392124-02c38f23-3032-4d96-a2b1-67d2f7c919a9.mp4

AnnettNFDI commented 2 years ago

Thanks for the improvement! Just a few comments:

TLC_reaction_properties

adambasha0 commented 2 years ago

Hi Annett, Thanks for the thorough feedback.

AnnettNFDI commented 2 years ago

Hi Adam, I talked to one of our active chemists about the TLC layouts. We agreed that the current draft is a bit unhandy. To us, it seems more useful to organise the documentation of TLC plate-wise. Therefore, we developed a draft for TLC documentation in samples and reactions. Of course, as you also mentioned the information should be connected (point 3 in you last comment). Our suggestion is to allow adding of a new TLC Control ( = a new TLC plate) and to have fields for eluent (solvent should be generally renamed to eluent. An eluent can contain a mixture of several solvents, which is often the case), for the sample/reactant/product and the respective Rf value and a field for TLC Description. As this should be the mandatory information for every TLC Control. If one does another TLC Control with another eluent than all the ifnormation should be entered again. The TLC descriptiopn field is important for all plates, as there are e.g. differnt plate types, methods for visualisation or dates, that should be recorded together with the values. If it is possible, we suggest to restrict tha valid values for Rf Value to 1.0, as this is always the eluent control and Rf Values for any sample must be smaller. As comment to your first point above: Ok, Now I understand. That was not clear for me from the video, but sounds absolutely reasonable ;).

  1. image: Suggestion for TLC in reactions
  2. image: Suggestion for tLC in samples Layout_TLC_reaction Layout_TLC_sample
SylviaVanderheiden commented 2 years ago

As a user I wish to upload and display a TLC plate image directly in the properties tab in the reactions element as there are also documented the information on TLC plate conditions.