search

ComPlat / chemotion_ELN

Electronic Lab Notebook
https://www.chemotion.net
GNU Affero General Public License v3.0
124 stars 46 forks source link

Adapt reaction element for catalysis and other usage #885

Open nicolejung opened 2 years ago

nicolejung commented 2 years ago

At the moment, the reaction scheme works only if at least one sample is assigned to the reaction. Also, without samples, the reaction arrow is given (and the rest is empty). For a broader use of the reaction element, it would be good to change it as follow:

dpatelev commented 2 years ago

I believe #691 corresponds to removal of the arrow svg until samples are added?

PiTrem commented 2 years ago

yes the first point is being released in v1.4

nicolejung commented 2 years ago

Thanks! Could also someone take the second step?

adambasha0 commented 1 year ago

Hello @nicolejung, this is quite simple, but this validation to save a reaction only with samples was probably made for a reason, question is what was it for, and don't we need it anymore?

adambasha0 commented 1 year ago

https://user-images.githubusercontent.com/55552142/200869568-30c85ae4-440d-42b0-a502-5f6b071a5076.mp4