search

Comau / eDO_core

eDO Ros core Package
http://eDO.Cloud
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

edo_description urdf looks for meshes in 'edo_sim' #3

Open gavanderhoorn opened 6 years ago

gavanderhoorn commented 6 years ago

The current edo_sim.urdf specifies the location of meshes to be edo_sim, instead of edo_description, leading to the meshes not being found (here fi).

IIRAI commented 5 years ago

I think that the fastest solution to your problem is to change the package name of edo_description, defined in its CMakeList.txt and package.xml files, to edo_sim.
This solves a problem with MoevIt too, which expects a package named edo_sim.

gavanderhoorn commented 5 years ago

Comau should fix this. They're making this package available.

Pro commented 5 years ago

I fixed many bugs in the official edo packages and with my fixes you can start the e.DO simulation in Gazebo and also with Moveit.

Check them out here: https://github.com/Pro/edo_gazebo

And all the other repo forks: https://github.com/Pro?utf8=%E2%9C%93&tab=repositories&q=edo&type=&language=

gavanderhoorn commented 5 years ago

That's very nice of you :+1: , but I believe Comau should maintain their packages :)

Perhaps you could kickstart the process by submitting some pull requests?

Pro commented 5 years ago

I already created pull requests. e.g. this one: https://github.com/Comau/eDO_description/pull/2

I also contacted comau directly, and the answer was, that comau itself does not develop this stuff and they can not merge it. Someone else has to do it. I ended up with just using my own forks, since they work flawlessly. We even used this in a student course.

Looks like comau still has to learn how to work with an open source community. The latest push on the eDO_core package was just a huge version bump. This makes it impossible to contribute back to the repositories. There should be constant commits while developing, and not just one commit per version.

gavanderhoorn commented 5 years ago

I also contacted comau directly, and the answer was, that comau itself does not develop this stuff and they can not merge it. Someone else has to do it.

Nice. That's good to know.

Thanks for your work.