search

Comau / eDO_core_msgs

eDO ROS messages
http://eDO.Cloud
BSD 3-Clause "New" or "Revised" License
1 stars 6 forks source link

SystemCommandSrv.srv missing #2

Open ymollard opened 5 years ago

ymollard commented 5 years ago

The problem commented there is still unsolved: https://github.com/Comau/eDO_core_msgs/commit/25a5054d8933dadcfc47a3cd7a5c13f2d36f1863

Why has SystemCommand.srv been renamed into SystemCommandSrv.srv while this file does not exist?

dbersan commented 4 years ago

Yep, and many other errors

dbersan commented 4 years ago

I won't make a PR for this because this seems to be a dead project, but if anyone has issues, here is the correct CMakeLists.txt: 

cmake_minimum_required(VERSION 2.8.3)
project(edo_core_msgs)

## Compile as C++11, supported in ROS Kinetic and newer
# add_compile_options(-std=c++11)

## Find catkin macros and libraries
## if COMPONENTS list like find_package(catkin REQUIRED COMPONENTS xyz)
## is used, also find other catkin packages
find_package(catkin REQUIRED COMPONENTS
  geometry_msgs
  message_generation
  roscpp
  std_msgs
)

## Generate messages in the 'msg' folder
 add_message_files(
   FILES
   JointState.msg
   JointStateArray.msg
   JointControl.msg
   JointControlArray.msg
   MovementCommand.msg
   MovementFeedback.msg
   JointConfiguration.msg
   JointInit.msg
   JointConfigurationArray.msg
   JointCalibration.msg
   JointReset.msg
   CartesianPose.msg
   JointsPositions.msg
   JointMonitoring.msg
   MachineState.msg
   NodeSwVersion.msg
   NodeSwVersionArray.msg
   JointFwVersion.msg
   JointFwVersionArray.msg
   Point.msg
   Frame.msg
   SystemCommand.msg
 )

## Generate services in the 'srv' folder

 add_service_files(
   FILES
   JointsNumber.srv
   DirectKinematics.srv
   InverseKinematics.srv
   SoftwareVersion.srv
   ControlSwitch.srv
   LoadConfigurationFile.srv ## 180305 GC&IL
 )

## Generate added messages and services with any dependencies listed here
 generate_messages(
   DEPENDENCIES
   geometry_msgs
   std_msgs
 )

catkin_package(
#  INCLUDE_DIRS include
#  LIBRARIES edo_core_msgs
  CATKIN_DEPENDS geometry_msgs message_generation roscpp std_msgs
#  DEPENDS system_lib
)

## Specify additional locations of header files
## Your package locations should be listed before other locations
include_directories(
# include
  ${catkin_INCLUDE_DIRS}
)
ymollard commented 4 years ago

@dhiegomaga I've transferred all my eDo-related repositories to a dedicated Github organization eDO Community. Feel free to make PR or request write access, on my side I don't have eDOs anymore so I can't test anything with actual robots, I think it's good if several people can handle these repos. @Bracewind @ianathompson @lucarinelli @ludusrusso you might also be interested in contributing there: eDO Community.

Bracewind commented 4 years ago

Seems to me that I cannot add my repositories to the organization.

Moreover, if you directly retrieve the package edo_core_msg from the edo robot, you don't have to manually add msg files. I don't recommend adding the message files, since you will be using msg structure that eDO v3 won't probably use, and so it will probably break (or do nothing).

ymollard commented 4 years ago

What does that mean to "retrieve the package edo_core_msg from the edo robot"? Your workstation needs msg files in some ROS package in your workspace. Do you mean make a copy from the robot?

Bracewind commented 4 years ago

Yes, it is exactly what I mean. When you connect using ssh, you have access to all files contained in the robot, and especially to the catkin directory of the robot, that contains all the ros packages (such as edo_core_msg). I do not work anymore on edo so I don't remember the path. If someone find it, it would be great to push it on a fork of this repository.