[Discussion]: Let ammo spawn weight (esp. at traders) be set to count of weapons with an ammoset containing it

[Alicecomma]

Complaints about current system (by TRIBAL PLAYERS):

• Weapon traders sell ammo that doesn't fit the guns they sell
• Bulk traders sell ammo that only fits highly specific turrets and that is otherwise rare (20mm Spanish artillery shells) - despite their supposed goal of bulk sales (5.56 NATO is uncommonly sold in bulk!). NOTE: This is because the current system assigns 'CE_Ammo' and 'CE_AmmoHeavy' to different trader kinds, the latter will always generate stuff like 20mm artillery shells.
• Exotic traders have the same distribution of ammo (e.g rare and common) as the other traders - they should sell based on a different metric
• Bases sell random ammo - they should sell turrets, ammo, shells, guns that they personally don't use, e.g sell 7.62 NATO if their guns are all 5.56 NATO.
• Pirates sell shells, which are the things they need to raid colonies - they should sell turrets, unused ammo, shells they can't fire, cheap guns..

Solutions:

All rely on A. Extended StockGen_Weapon, B. Extended StockGen_MiscItem specific for ammo, C. Extended StockGen_MiscItem for exotic gun (not its common ammo), exotic ammo or exotic gun plus its exotic ammo.

• Weapon (and turret) traders carry ammo for the guns they sell --> Extend StockGen_Weapon to also generate ammo
• Have bulk traders carry the most common ammo (commonly generated), no heavy ammo --> New StockGen_CommonAmmo
• • Option 1. Prepare sums: set ammo spawn weights by count of weapons with an ammoset containing it (loop ammosets, sum weapons using it, add to spawn weight of each ammo in the ammoset the count of weapons using it), and in a final step multiply by XML spawnweight (best of both worlds - dynamic and mutable)
• • Option 2. Use raider gun generation code: generate random weapons within a certain marketValue range (like for pawnkinds), sell ~10x the amount of mags those guns need at full load.
• Have exotic traders carry ammo with higher market values? Have them do the same thing as currently?
• New StockGen that considers current gun/ammo used by the base/pirates and sells those things that aren't used by them

[Alicecomma]

Core StockGenerators related to weapons and ammo:

• Base_Outlander_Standard: 1-4x reinforced barrel, 1-2x 10-20 mortar shells
• Caravan_Outlander_BulkGoods: 1-4x reinforced barrel
• Caravan_Outlander_CombatSupplier: 5x StockGenerator_WeaponsRanged, 3-15x 1-2 mortar shells
• Caravan_Outlander_PirateMerchant: 1-10x 1-2 mortar shells
• Caravan_Outlander_Exotic: None (unless tagged exotic)
• Orbital_BulkGoods: None
• Orbital_CombatSupplier: 5-10x reinforced barrel, 10-14x StockGenerator_WeaponsRanged, 20-40x 1-2 mortar shells
• Orbital_Exotic: None (unless tagged exotic)
• Orbital_PirateMerchant: 1-2x StockGenerator_WeaponsRanged
• Visitor_Outlander_Standard: 1-4x reinforced barrels, 0-1x StockGenerator_WeaponsRanged

Current ammo StockGenerator_Tag additions :

• Base_Outlander_Standard: 5-9x 500-2,000 CE_Ammo rounds, 3-6x 10-100 CE_HeavyAmmo rounds, 0-4x 1-2 CE_Turret turrets
• Caravan_Outlander_BulkGoods: 1-4x 200-400 CE_Ammo rounds, 1-3x 5-20 CE_HeavyAmmo rounds
• Caravan_Outlander_CombatSupplier: 3-8x 400-1,000 CE_Ammo rounds, 2-5x 10-50 CE_HeavyAmmo rounds, 0-2x 1 CE_Turret turret
• Caravan_Outlander_PirateMerchant: 1-4x 200-400 CE_Ammo rounds, 1-3x 5-20 CE_HeavyAmmo rounds
• Caravan_Outlander_Exotic: 1-4x 200-400 CE_Ammo rounds, 1-3x 5-20 CE_HeavyAmmo rounds
• Orbital_BulkGoods: 1-4x 400-1,000 CE_Ammo rounds, 1-3x 15-100 CE_HeavyAmmo rounds
• Orbital_CombatSupplier: 5-12x 1,000-3,000 CE_Ammo rounds, 3-8x 100-500 CE_HeavyAmmo rounds, 0-4x 1-2 CE_Turret turrets
• Orbital_Exotic: 1-4x 400-1,000 CE_Ammo rounds, 1-3x 15-100 CE_HeavyAmmo rounds
• Orbital_PirateMerchant: 1-4x 400-1,000 CE_Ammo rounds, 1-3x 15-100 CE_HeavyAmmo rounds
• ! Visitor_Outlander_Standard never patched !

Comments:

• Base sells turrets, shells and ammo, which could be used against them [Perhaps they only sell 'older' = cheaper turrets, shells and ammo?]
• Exotic sells non-exotic ammo and heavy ammo [These probably shouldn't sell ammo (unless tagged exotic), and probably sell exotic guns with respective ammo]
• Combat does sell guns, but the sold ammo isn't for those guns [Should definitely sell ammo for their sold guns]
• Pirate may not sell guns [Perhaps they shouldn't sell bullets at all?]
• Bulk sells ammo and heavy ammo but no guns [Idea was to spawn based on generate commonality of guns - ideally they don't sell shells cause they're not all that 'bulk'?]
• Visitor sells a gun but no ammo [Should probably sell ammo for their gun]

[Alicecomma]

Future ammo custom StockGenerator:

• Base_Outlander_Standard: Only sell rounds and turrets they don't use and that are low-power or low-value -- kind of a yard sale type of trader. Perhaps sell cheap guns. Essentially their loot came from raiders, so the raider generation code would work fine for their stocks - except for they took the best guns and the ammo that they don't need.
• Caravans should always sell less than orbital.
• Bulk goods caravan should not carry HeavyAmmo. Their Ammo should be distributed by commonality of ammo for guns - they're trying to make a profit, targeting the most common.
• Exotic should only sell exotic-tagged guns without their common ammo, exotic-tagged ammo, or exotic-tagged guns PLUS their exotic ammo.
• Combat should sell ammo for the guns AND turrets they sell.
• Pirate caravan - these guys raid bases which takes them mortar shells. They should sell unused shells, guns they don't use and sell turrets.

[N7Huntsman]

This is because the current system assigns 'CE_Ammo' and 'CE_AmmoHeavy' to different trader kinds, the latter will always generate stuff like 20mm artillery shells.

Just as a general note, CE_HeavyAmmo was created to handle some of the heavier shells and explosives so they're available in more sane quantities, primarily to deal with the issue of traders sometimes spawning with 300 81mm mortar shells and nuking a large chunk of the map when they wander into trouble.