CombatExtended-Continued / CombatExtended

Combat Extended mod for RimWorld
377 stars 254 forks source link

[Bug]: Vanilla Vehicles Expanded vehicles exploding forever #2898

Open That0nePerson opened 11 months ago

That0nePerson commented 11 months ago

Rimworld version: 1.4.3901 rev238 Combat Extended version: 1.4.5.5 Combat Extended source (Steam, GitHub, etc.): Steam Your operating system: Windows Your mod list:

Description When VVE vehicles' fuel tanks or engines are damaged, they explode and set fire to the vehicle while doing no damage to the parts the explosion came from or any surrounding parts. If the armor surrounding the tank or engine is destroyed, the fire continuously triggers the explosions of the chemtank and engine. Generally, it also makes vehicles extremely hard to destroy as you have to break each part down to 0% individually. This may be caused by the vehicle's armor and fire armor being stronger than the damage dealt by the explosion and fire, which I believe might be tricky to fix without making the explosions overly powerful. This does not happen with just VVE, and the Vehicle Framework discord said this was a CE issue.

Expected behavior When explosive parts on a vehicle are damaged, the explosion goes off once or twice and destroys the vehicle.

To reproduce Build a bulldog from VVE, fire at the fuel tank with a weapon that can penetrate the armor, wait for it to explode and set the vehicle on fire.

Screenshots & log dumps

https://github.com/CombatExtended-Continued/CombatExtended/assets/63219222/b09cd516-d345-4737-a706-5116e0032db8

https://pastebin.com/A3TfEtAw

Complete the following checklist I hereby verify that I have done the following:

TurklerRS commented 10 months ago

I want to add something that the original posted forgot in this issue.

image

Fuel from vehicles burning off causes infinite explosions that effectively stack forever. If a vehicle has fuel, which is very likely as they need fuel to be operated, and takes damage then they will continue spawning explosions that quickly make the make unplayable until the whole tank burns off. For reference, the performance slowdown is so severe that in 30 minutes only half the tank of a truck was able to burn off as the massive amounts of explosions prevent anything from being properly ticked.