search

CombatExtended-Continued / CombatExtended

Combat Extended mod for RimWorld
371 stars 250 forks source link

CE\Biomes! Caverns patching issue #2924

Closed MagicalCow closed 8 months ago

MagicalCow commented 9 months ago

Rimworld version: 1.4.3901 Combat Extended version: Steam 1.4.5.5 OS: Windows 10 Modlist: https://rentry.co/c3mys

Description I isolated that two mods causing error - it seems that CE cant patch some spider definitions and Im not sure which side is causing troubles.

Error log is:

[Combat Extended] Patch operation Verse.PatchOperationFindMod(Biomes! Caverns) failed
file: C:\Games\Steam\steamapps\workshop\content\294100\2890901044\Patches\Biomes Caverns\ThingDefs_Races\CE_WoolySpider.xml
UnityEngine.StackTraceUtility:ExtractStackTrace ()
Verse.Log:Error (string)
Verse.PatchOperation:Complete (string)
Verse.LoadedModManager:ClearCachedPatches ()
Verse.LoadedModManager:LoadAllActiveMods ()
Verse.PlayDataLoader:DoPlayLoad ()
Verse.PlayDataLoader:LoadAllPlayData (bool)
Verse.Root/<>c:<Start>b__6_1 ()
Verse.LongEventHandler:RunEventFromAnotherThread (System.Action)
Verse.LongEventHandler/<>c:<UpdateCurrentAsynchronousEvent>b__27_0 ()
System.Threading.ThreadHelper:ThreadStart_Context (object)
System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object)
System.Threading.ThreadHelper:ThreadStart ()

I will double that issue to the steam workshop of Biomes as well.

N7Huntsman commented 8 months ago

This appears to be the result of a minor typo/update from the mod. In the mod, the defName is BMT_WoollySpider but in the patch is referred to as BMT_WoolySpider, causing the patch to fail. I'll add the fix to a PR.

alreShan commented 5 months ago

Request patch, for diggerpede

#2024-3-26_1 #2024-3-26_2

Error 1 #2024-3-26_Error1

Trying to get stat MeleeArmorPenetration from BMT_Diggerpede which has no support for Combat Extended.
UnityEngine.StackTraceUtility:ExtractStackTrace ()
(wrapper dynamic-method) Verse.Log:Verse.Log.Error_Patch7 (string)
CombatExtended.StatWorker_MeleeArmorPenetration:GetFinalDisplayValue (RimWorld.StatRequest)
CombatExtended.StatWorker_MeleeArmorPenetration:GetStatDrawEntryLabel (RimWorld.StatDef,single,Verse.ToStringNumberSense,RimWorld.StatRequest,bool)
RimWorld.StatDrawEntry:get_ValueString ()
BetterInfoCard.StatsReportUtility_Instanced:FinalizeCachedDrawEntries (System.Collections.Generic.IEnumerable`1<RimWorld.StatDrawEntry>)
BetterInfoCard.StatsReportUtility_Instanced:DrawStatsReport (UnityEngine.Rect,Verse.Thing)
BetterInfoCard.Dialog_InfoCard_Patch:DrawStatsReportInstanced3 (UnityEngine.Rect,Verse.Thing,Verse.Dialog_InfoCard)
(wrapper dynamic-method) Verse.Dialog_InfoCard:Verse.Dialog_InfoCard.FillCard_Patch2 (Verse.Dialog_InfoCard,UnityEngine.Rect)
(wrapper dynamic-method) Verse.Dialog_InfoCard:Verse.Dialog_InfoCard.DoWindowContents_Patch2 (Verse.Dialog_InfoCard,UnityEngine.Rect)
(wrapper dynamic-method) Verse.Window:Verse.Window.InnerWindowOnGUI_Patch2 (Verse.Window,int)
UnityEngine.GUI:CallWindowDelegate (UnityEngine.GUI/WindowFunction,int,int,UnityEngine.GUISkin,int,single,single,UnityEngine.GUIStyle)

Error 2 #2024-3-26_Error2

Exception filling window for Verse.Dialog_InfoCard: System.InvalidCastException: Specified cast is not valid.
  at CombatExtended.StatWorker_MeleeArmorPenetration.GetExplanationUnfinalized (RimWorld.StatRequest req, Verse.ToStringNumberSense numberSense) [0x00094] in <b3dfa5dad8ec4e63921516d7d62f8d8b>:0 
  at (wrapper dynamic-method) RimWorld.StatWorker.RimWorld.StatWorker.GetExplanationFull_Patch2(RimWorld.StatWorker,RimWorld.StatRequest,Verse.ToStringNumberSense,single)
  at RimWorld.StatDrawEntry.GetExplanationText (RimWorld.StatRequest optionalReq) [0x00040] in <cd7169108ea74757aa50c5b33d275c15>:0 
  at BetterInfoCard.StatsReportUtility_Instanced.DrawStatsWorker (UnityEngine.Rect rect, Verse.Thing optionalThing, RimWorld.Planet.WorldObject optionalWorldObject) [0x0034a] in <e86287ab62f84da9b43d4270d5c2ed9e>:0 
  at BetterInfoCard.StatsReportUtility_Instanced.DrawStatsReport (UnityEngine.Rect rect, Verse.Thing thing) [0x000a1] in <e86287ab62f84da9b43d4270d5c2ed9e>:0 
  at BetterInfoCard.Dialog_InfoCard_Patch.DrawStatsReportInstanced3 (UnityEngine.Rect rect, Verse.Thing thing, Verse.Dialog_InfoCard dialog) [0x0000a] in <e86287ab62f84da9b43d4270d5c2ed9e>:0 
  at (wrapper dynamic-method) Verse.Dialog_InfoCard.Verse.Dialog_InfoCard.FillCard_Patch2(Verse.Dialog_InfoCard,UnityEngine.Rect)
  at (wrapper dynamic-method) Verse.Dialog_InfoCard.Verse.Dialog_InfoCard.DoWindowContents_Patch2(Verse.Dialog_InfoCard,UnityEngine.Rect)
  at (wrapper dynamic-method) Verse.Window.Verse.Window.InnerWindowOnGUI_Patch2(Verse.Window,int)
UnityEngine.StackTraceUtility:ExtractStackTrace ()
(wrapper dynamic-method) Verse.Log:Verse.Log.Error_Patch7 (string)
(wrapper dynamic-method) Verse.Window:Verse.Window.InnerWindowOnGUI_Patch2 (Verse.Window,int)
UnityEngine.GUI:CallWindowDelegate (UnityEngine.GUI/WindowFunction,int,int,UnityEngine.GUISkin,int,single,single,UnityEngine.GUIStyle)