Miho and ammo - Githubissues

Tostov commented 4 months ago

Additions

Non-Mod Specific nailgun and HV nailgun, as well as ammo for 47x398mmR and 57x280mmR shells. Miho specific ammunition for the aformentioned cannon shells (race specific AP-I for the 47, race specific canister and thermobaric for the 57), as well as a few other calibers they use (AP-I variants). https://docs.google.com/spreadsheets/d/1MTHK21vMpdeQG12cwJu8P3bDIndNRs_l4OVt1EmSE_o/edit?usp=sharing

Patches for the new stuff, incl. rocket launcher which while guided in vanilla we cannot do yet, so it's dumbfire for the moment.

Changes

Caliber changes for a number of weapons based on descriptions. (40mm grenade to 20mm grenade, 50mm rocket to 57mm rocket). Changed the 57mm grenade launcher for a 57mm cannon that it is actually supposed to be. The 100mm incendiary rockets are now explosive/thermobaric as their vanilla performance is.

Removed patches for stuff that is no longer in the mod.

Reasoning

The 57mm gun is pretty obviously supposed to be the other jap tank cannon after a bit of poking around (https://en.wikipedia.org/wiki/Type_97_Chi-Ha_medium_tank the 57 and 47 are armaments for this tank). The AP-I, thermobaric and canister shots for the cannons are left to being mod specific because none of them were actual loads for the guns.

The 13.2mm HMG caliber is probably supposed to be 13.2×99mm Hotchkiss rather than 13.2mm TuF, but the two calibers are probably extremely close in spec (51.5@785 vs 52@790), and we don't actually have 13.2x99mm.

Alternatives

We could add the other calibers to the generics (with regular damage). It's probably not entirely unreasonable to give both the 47/57mm guns APHE/AP-I rounds either but falls outside of kind of the main scope of adding the base shells.

Testing

Check tests you have performed:

[x] Compiles without warnings
[x] Game runs without errors
[x] (For compatibility patches) ...with and without patched mod loaded
[ ] Playtested a colony (specify how long)

github-actions[bot] commented 4 months ago

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9123947718.zip

github-actions[bot] commented 4 months ago

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9124047665.zip

github-actions[bot] commented 4 months ago

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9132117388.zip