Give Ammo Float Menu Typo Fix - Githubissues

CombatExtended-Continued / CombatExtended

Combat Extended mod for RimWorld

369 stars 248 forks source link

Give Ammo Float Menu Typo Fix #3144

Closed ViralReaction closed 3 months ago

ViralReaction commented 3 months ago

Changes

Describe adjustments to existing features made in this merge, e.g.

Changes code to allow translations to use {0} in place of subject
Update existing English, Chinese Simplified, and Portuguese translations to utilize correctly

Reasoning

Why did you choose to implement things this way, e.g.

Allows translations that do not follow same sentence structure as English to have proper translation

Alternatives

Describe alternative implementations you have considered, e.g.

Add a space directly in the C# code
- Not as flexible as using {0} for the subject
Leave typo of "Give Ammo to{SUBJECT]" on float menu

Testing

Check tests you have performed:

[x] Compiles without warnings
[ ] Game runs without errors
[ ] Playtested a colony (specify how long)

github-actions[bot] commented 3 months ago

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9141078059.zip