Apparel_Shield support for xml offsets and directional textures

Merwini commented 3 months ago

Additions

Added GraphicData field to ShieldDefExtension
Added four Vector3 draw offset fields to ShieldDefExtension, one for each cardinal direction

Changes

Apparel_Shield now checks the draw offsets from ShieldDefExtension instead of using hardcoded ones. Defaults are identical to existing hardcoded values.
Apparel_Shield now checks if ShieldDefExtension has a GraphicData defined, or uses the def's GraphicData if not. Draws shields using this graphic data, allowing for different textures based on pawn facing.

References

N/A

Reasoning

Allows better configuration for shields
Some guy asked me to
Using the same texture for shield no matter which way the pawn is facing looks dumb

Alternatives

Leave as-is

Testing

Check tests you have performed:

[x] Compiles without warnings
[x] Game runs without errors
[ ] (For compatibility patches) ...with and without patched mod loaded
[x] Playtested a colony (spawned 20 colonists with shields and various weapons, and had them fight a 2000 pt tribal raid)

github-actions[bot] commented 3 months ago

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9217127239.zip

Merwini commented 3 months ago

I'm Nuff on Discord if you need to get ahold of me This is unrelated to the 1.5 update

github-actions[bot] commented 3 months ago

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9246598461.zip

github-actions[bot] commented 3 months ago

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9331882612.zip

github-actions[bot] commented 2 months ago

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9503838803.zip

N7Huntsman commented 2 months ago

While direction textures could still be quite useful for shields, this PR will need re-evaluated with the switch to the vanilla renderer for the shields.

Merwini commented 2 months ago

Switch to vanilla rendering allows for directional textures by changing graphicClass to Graphic_Multi, and allows for xml-defined directional offsets in renderNodeProperties. PR is redundant. Closed.

CombatExtended-Continued / CombatExtended