Closed Rhinous closed 1 day ago
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9433968925.zip
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9723296193.zip
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9732193285.zip
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9733647817.zip
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9734334689.zip
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9740613201.zip
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9740900366.zip
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9741322058.zip
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9797059186.zip
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9802141735.zip
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9808770883.zip
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9808909325.zip
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9809482655.zip
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9867476663.zip
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9867886281.zip
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9867933577.zip
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9868081116.zip
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9868364546.zip
Inheritance should be sorted now to not have a ton of duplicated code, shield logic also updated.
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9868532855.zip
Split some functionality into #3278 and #3279 will need to add the ground defense mode logic to another PR afterwards
Cleaned up and added GroundDefenseMode functionality to #3282 making this now obsolete
Additions
Added support for SOS2 shields to intercept
ProjectileCE
Patched ship weapons GroundDefenseMode by creating a new building
Building_ShipTurretCE
and new verbVerb_ShootShipCE
that uses CE logic on the ground while keeping the SOS2 logic for space combatChanges
Updated SOS2 Reference assembly
Updated Vehicle Framework Reference Assembly
Updated SOS2 Torpedo tube reload patch
Moved all SOS2 patching to its own project similar to the VehicleFramework patch
Added
virtual
toTryCollideWithRoof
inProjectileCE
so that the roof collision logic can be overwritten, stopping the player from accidentally blowing up their own spaceship's roof if the shot misses its targetChanged the access level of a few fields/methods in
Verb_LaunchProjectileCE
fromprivate
toprotected
, changednumShotsFired
inVerb_ShootMortartCE
to aprivate new int
to work with this changeMade
CELogger
andJobGiverUtils_Reload
classes public (So they can be accessed from the separate SOS2Compat Project)References
Reasoning
Alternatives
Testing
Check tests you have performed: