CombatExtendedRWMod / CombatExtended

Combat Extended mod for RimWorld
128 stars 91 forks source link

Add Red Horse Faction - Last Man Contingent patches #1102

Closed sumghai closed 4 years ago

sumghai commented 4 years ago

Patches brought over as part of the FastTrack merger, and updated to RimWorld 1.1 standards

Notes:

sumghai commented 4 years ago

The apparel values currently specified are on par with what we expected, and are comparable to the fabric garments you previously reviewed for the WWII Soviet Faction patches.

As for consolidating ranged weapon melee tools, I'll definitely keep that in mind for brand-new patches in the future, although it'll be a bit too late for the existing FT patches being brought over.

ASIDE: Why patches for Rimmu-Nation / Project Red Horse mods are inefficient Chicken Plucker made each of his faction mods by copying and pasting selected chunks of XML defs from a larger library of weapons and apparel (i.e. the RN Weapons and RN Clothing compilation mods). For expediency, I would similarly copy and paste the relevant patches for each compatibility patch folder, with the expectation that each weapons' melee tools could be individually tweaked later if necessary. Besides, CP does have a tendency to add or remove content on a whim, so being able to quickly erase entire chunks of XML would at the time have been a bit faster than deleting individual lines from consolidated patches. Of course, now that CE is aiming to simplify the process by standardizing melee tool stats for each of the most common weapon type groupings - handguns, rifles/machine guns and rocket launchers - if I were to start patching the RN / RH mods today for the first time, I would definitely have consolidated melee tool patches as much as possible.
zhrocks11 commented 4 years ago

@sumghai @N7Huntsman If you guys can I need you to take another look at this - Multiple issues coming up with this patch - Sent to me by another user I have not yet tested myself - Please See the Image here https://imgur.com/a/GH4Hf6P