CombatExtendedRWMod / CombatExtended

Combat Extended mod for RimWorld
128 stars 91 forks source link

Add Magical Menagerie patches #1130

Closed sumghai closed 4 years ago

sumghai commented 4 years ago

Patches brought over as part of the FastTrack merger, and updated to RimWorld 1.1 standards

Notes:

N7Huntsman commented 4 years ago

Everything within the patch looks fine--I assume this has been tested to ensure it's completely functional? I seem to recall MM using some unconventional verbs for their creature ranged attacks.

sumghai commented 4 years ago

Yes, these patches have been tested to my satisfaction.

I've updated the attacks/tools to use armor penetration values where appropriate - any tool without them weren't supposed to have them (e.g. flame or poison breath attacks aren't affected by armor)

sumghai commented 4 years ago

@N7Huntsman and playtesters

I am unable to reproduce the issue on my end, when running a minimal installation of the following:

Annotation 2020-03-27 194925

No error messages appear at the main menu screen, starting a new save, spawning two of each creature using the dev menu, inspecting each creature's info box, spawning Mechanoids to attack the creatures etc.

How many playtester(s) have experienced this issue? What is their modlist?

yackemflam commented 4 years ago

turns out that I didn't know about this pr.

No errors on my end, sorry about the confusion

N7Huntsman commented 4 years ago

@sumghai Approved. Sorry, no errors, just a miscommunication with the playtester.

sumghai commented 4 years ago

@N7Huntsman @yackemflam - All good, thanks for the clarification.