CombatExtendedRWMod / CombatExtended

Combat Extended mod for RimWorld
129 stars 91 forks source link

Vanilla expanded factions/medieval crossbow is incompatible #1197

Closed Brumes-Wolf closed 4 years ago

Brumes-Wolf commented 4 years ago

While the new version says the medieval faction is now compatible, the heavy crossbow throws errors and does not seem to have ammo/other CE stats

ghost commented 4 years ago

Mind showing the error or linking a hugslib log?

Brumes-Wolf commented 4 years ago

It alternatingly spams the log with these 2 messages upon selecting the crossbow

Trying to get stat MeleeArmorPenetration from VFEM_Bow_HeavyCrossbow which has no support for Combat Extended.
Verse.Log:Error(String, Boolean)
CombatExtended.StatWorker_MeleeArmorPenetration:GetStatDrawEntryLabel(StatDef, Single, ToStringNumberSense, StatRequest, Boolean)
RimWorld.StatDrawEntry:get_ValueString()
RimWorld.StatDrawEntry:Draw(Single, Single, Single, Boolean, Action, Action, Vector2, Rect)
RimWorld.StatsReportUtility:DrawStatsWorker(Rect, Thing, WorldObject)
RimWorld.StatsReportUtility:DrawStatsReport(Rect, Thing)
Verse.Dialog_InfoCard:FillCard(Rect)
Verse.Dialog_InfoCard:DoWindowContents(Rect)
Verse.Window:InnerWindowOnGUI(Int32)
UnityEngine.GUI:CallWindowDelegate(WindowFunction, Int32, Int32, GUISkin, Int32, Single, Single, GUIStyle)

Trying to get stat MeleeDamage from VFEM_Bow_HeavyCrossbow which has no support for Combat Extended.
Verse.Log:Error(String, Boolean)
CombatExtended.StatWorker_MeleeDamage:GetStatDrawEntryLabel(StatDef, Single, ToStringNumberSense, StatRequest, Boolean)
RimWorld.StatDrawEntry:get_ValueString()
RimWorld.StatDrawEntry:Draw(Single, Single, Single, Boolean, Action, Action, Vector2, Rect)
RimWorld.StatsReportUtility:DrawStatsWorker(Rect, Thing, WorldObject)
RimWorld.StatsReportUtility:DrawStatsReport(Rect, Thing)
Verse.Dialog_InfoCard:FillCard(Rect)
Verse.Dialog_InfoCard:DoWindowContents(Rect)
Verse.Window:InnerWindowOnGUI(Int32)
UnityEngine.GUI:CallWindowDelegate(WindowFunction, Int32, Int32, GUISkin, Int32, Single, Single, GUIStyle)

And this is what the crossbow looks like, no ammo, vanilla accuracy stats etc. https://i.imgur.com/yVnEAeI.png I'm not running hugslib since it isn't a requirement for either mod?

ghost commented 4 years ago

Oh yeah, this was fixed but it's not on steam yet. A way to fix this asap is go here copy it's contents then go to CE's folder in your steam mods folder which should be 1631756268 > Patches > Vanilla Factions Expanded - Medieval> ThingDefs_Misc > VanillaMedieval_Ranged.xml and replace the content with the one you copied

And for the record many mods use HugsLib even if it's not specified it's like common knowledge.

Brumes-Wolf commented 4 years ago

Alright, Hugslib is in the modpack, I only turned on the required mods for testing purposes though. Its not something I need fixed right away since i'm not even playing yet, waiting for a few mods to update. But I wanted to let you guys know about this thing. keep up the good work. CE is awesome