CombatExtendedRWMod / CombatExtended

Combat Extended mod for RimWorld
128 stars 91 forks source link

Disproportional mass-to-bulk for certain things #54

Open Alicecomma opened 7 years ago

Alicecomma commented 7 years ago

For example Go-Juice has mass 0.04kg or 40g (500 mL PET bottles are ~20 g, so let's say it's a heavy ~340 mL bottle) in total with a bulk of 1.00 (340 mL) while beer has a mass of 0.5 kg or 500g (could be accurate for a 340 mL beer bottle) and a bulk of 1.00 (340 mL) as well. Rationally speaking, a 340 mL bottle should hold roughly 340 g of both beer and go-juice - yet go-juice appears weightless or its container is disproportionally bulky.

Someone should go through the mass/bulk of things and make them more sensible.

frenchiveruti commented 7 years ago

Well... you are confusing two different measures, that are Volume, and Weight. without considering density. Go-Juice, as it's a beverage that "speeds up" pawns, should be less dense therefore less heavy (for the same 340mL bottle) as it represents the properties that it provides to the colonists.

frenchiveruti commented 7 years ago

Take for example this: https://www.reddit.com/r/askscience/comments/5l4x0h/what_is_the_lightest_liquid_and_what_would_a/

Alicecomma commented 7 years ago

I don't want to discuss density here, it is the fact that carrying ten bottles of beer makes sense to cost 5 kg and 3.4 liters of space whereas it doesn't make sense that ten charges of go-juice cost 0.4 kg and 3.4 liters of space. Go Juice needs its weight increased to be in line with beer or its bulk decreased to be more in line with (0.4 / 5) * 3.4 ~= 0.275 liters.

frenchiveruti commented 7 years ago

But again! You can have a balloon full of helium that it has a Volume of 3.4L, and it weighs nothing!

NoImageAvailable commented 7 years ago

I think between the fact that this change would require lots of work to change one line in a whole bunch of defs (thereby creating potential conflicts) I think this is an issue best revisited once A17 adds an XML patcher to vanilla.

NoImageAvailable commented 7 years ago

Reopened now that A17 is released

frenchiveruti commented 7 years ago

I again say that Volume isn't the same as weight! haha

Alicecomma commented 4 years ago

I've got a Google Sheets file for A16 specifically if anyone's interested in seeing the progress I had made at that point:

https://docs.google.com/spreadsheets/d/1UMtjnZ6Auo3LhHIYyy64ii8h0RdrBkcK-7xnemsw6DQ/edit?usp=sharing

Alicecomma commented 4 years ago

Additional ideas:

N7Huntsman commented 4 years ago

It seems to me that the amount of meat provided from butchering is already controlled by baseBodySize, and meat amount is already affected by the butcher's cooking skill. Why change that? What's the benefit?

Alicecomma commented 4 years ago

The difference is animal corpse bulk (m^3) is much larger than baseBodySize which is a measure of height (m).